build: add urcrypt
#90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
c5d3e99
to
6b7e21b
Compare
eamsden
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Marker review to make sure we audit the licenses of everything going into this codebase. @matthew-levan please reply to this review comment with a checklist of vendored libraries and a list of their licenses.
matthew-levan
force-pushed
the
msl/urcrypt
branch
4 times, most recently
from
b601e9e
to
f1c0eb1
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
f1c0eb1
to
ef382a8
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
61ccc2e
to
d893931
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
d893931
to
589899b
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
296f437
to
58af42e
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
e2331d3
to
4ea4624
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
815c845
to
8a07ad5
Compare
matthew-levan
force-pushed
the
msl/urcrypt
branch
from
f5b2a67
to
40e04e8
Compare
eamsden
requested changes
Nov 7, 2023
| @@ -14,5 +14,6 @@ pkgs.mkShell { | |||
| ]) | |||
| cargo-watch | |||
| gdb | |||
| secp256k1 | |||
There was a problem hiding this comment.
urcrypt should be built in the Nix environment. We should not require global installs of any package for developers.
|
I'll leave this open for now but it's likely to close in favor of #123 shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
urcrypt-sys, a crate that provides Rust bindings tourcrypt, which is now required as a system dependency for building Ares. Also adds dependency installation commands in the CI script.